If you are putting them in boxes or dealing with tying ribbon.. I would definitely start that portion of the project. I wouldn't add the M&Ms until about 2 weeks prior.
If you are absolutely strapped for time near your wedding... it is better to start early than stress out or not finish them on time.
Re: Favors