There are very few weddings that I've been to over the years where I can remember what the favors were. Most were edible, I know that (and so was everything else at the reception...). I just don't see the point in spending money on yet one more edible thing for my wedding that I personally don't care about when that money could be going towards things for my guests that I DO care about (like the catering and cake...).
I like the idea of favors that last... But I know my guests don't care to have a little trinket of some kind with our names and wedding date plastered all over them...
One of my friends had their wedding at a vineyard and they did wine glasses as favors, which I thought was a great idea, but wine isn't "our thing". We like it, drink it occasionally...but it doesn't at all represent who we are as a couple. And neither does a measly piece of chocolate or a book of matches with our picture on it. I guess what I'm saying is, that if I'm going to send my guests home with something, I want it to be something they'll use or enjoy for more than a bite or, worse yet, throw in the trash.
I'm sure there's mixed feelings out there...but am I the only one who thinks favors are just something for us to spend more money on when they're just a little thing that the guests don't really care about anyway???